[issue-562] Serverless workflow pod gets restarted repeatedly after native K_SINK injection #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianrongzhang89
force-pushed
the
issue-562
branch
from
fab5b1d to
5e6adb1
Compare
wmedvede
reviewed
Nov 7, 2024
…native K_SINK injection
jianrongzhang89
force-pushed
the
issue-562
branch
from
d209c9a to
83c55ab
Compare
wmedvede
approved these changes
Nov 8, 2024
ricardozanini
approved these changes
Nov 8, 2024
wmedvede
pushed a commit
to wmedvede/kogito-serverless-operator
that referenced
this pull request
Nov 12, 2024
…native K_SINK injection (apache#565) (cherry picked from commit 5dae96c)
rgdoliveira
pushed a commit
to kiegroup/kogito-serverless-operator
that referenced
this pull request
Nov 12, 2024
…native K_SINK injection (apache#565) (#93) (cherry picked from commit 5dae96c) Co-authored-by: Jianrong Zhang <[email protected]>
rgdoliveira
pushed a commit
to rgdoliveira/kogito-serverless-operator
that referenced
this pull request
Nov 18, 2024
…native K_SINK injection (apache#565)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #562.
Description of the change:
The reason why the 00001-deployment pod gets restarted repeatedly is because after K_SINK injection, a new Knative revision has been created, and the workflow managed properties configmap has been updated to use the the K_SINK environment variable. As such the first deployment ****_00001 has become outdated and no longer aligned with the configmap and this causes the repeated pod restarting.
The fix is to clean up the outdated Knative revision(s) after the K_SINK injection is done (ie, sinkbinding is ready).
Motivation for the change:
To prevent 00001-deployment pod from getting restarted repeatedly.
Checklist