-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kie-issues#1679 : If the bottom of the overlay panel is close to editor bottom, it adds a vertical overflow after toggling an option #2845
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. I am not sure what should be my review (approve/not appprove) because:
On m machine by default the scrollbar is needed. Since the ticket was created, we added an entry into overlay panel (evaluation highlights) and also this maybe related to:
- user screen resolution
- browser setup, for example I am using tabs in the top , so the space for webpage is smaller
In other words, in my setup the scrollbar is not needed only if I turn browser into full screen mode.
@jomarko Please zoom out to see the issue. |
Hi @ljmotta , Can you please check it once and if it is still there we can connect once to see the issue as i am not seeing the issue on my machine now. |
@ljmotta should I use browser zoom feature or editor zoom feature? |
@Kusuma04-dev Which browser are you using? Maybe you can't reproduce because of that. Now, the behavior is different. bug-overlay.mp4 |
closed by #2845 |
Hey @Kusuma04-dev, you don't need this comment to link this PR with the ticket. You just need to write in the description |
@Kusuma04-dev Could you please add a video of the current solution? |
64bc835
to
c6a4a6d
Compare
Uploading Screen Recording 2025-01-19 at 8.01.55 PM (1) (1).mov… |
Screen.Recording.2025-01-19.at.8.01.55.PM.1.1.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kusuma04-dev The change is working! I've added a last comment inline.
closes apache/incubator-kie-issues#1679 - If the bottom of the overlay panel is close to editor bottom, it adds a vertical overflow after toggling an option