This repository has been archived by the owner on Feb 8, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @huafengw
This is work in process and even doesn't compile (breaking
RemoteMaterializerImpl
). The motivation is to make user application even simpler fromto
and address the following issues I find
StreamApp
is implicitly converted toStreamApplication
forcontext.submit
. It can be broken if a user forgets to import the conversion (and user doesn't know where it is).class StreamApp(name: String, system: ActorSystem, userConfig: UserConfig, private val graph: Graph[Op, OpEdge])
. We'd better make the constructor private if it's not intended for users.RunningApplication
andClientContext
have aaskAppMaster
method to query application status. How should their roles be divided ?RunningApplication
has no ScalaDoc.One downside about the new way is we can't close
ClientContext
and its underlyingActorSystem
. Is it a big problem ?