Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(remoting): unit test #599

Merged
merged 1 commit into from
Aug 3, 2023
Merged

test(remoting): unit test #599

merged 1 commit into from
Aug 3, 2023

Conversation

air-3
Copy link
Contributor

@air-3 air-3 commented Aug 3, 2023

What this PR does:

  1. unit test for XidLoadBalance
  2. XidLoadBalance bug fix

Which issue(s) this PR fixes:
session is nil, RemoteAddr method cannot be called directly

Fixes #587

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

1、unit test for XidLoadBalance 2、XidLoadBalance bug fix
@codecov-commenter
Copy link

Codecov Report

Merging #599 (dd9028c) into master (5835f09) will increase coverage by 0.21%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #599      +/-   ##
==========================================
+ Coverage   37.03%   37.25%   +0.21%     
==========================================
  Files         175      175              
  Lines       11659    11659              
==========================================
+ Hits         4318     4343      +25     
+ Misses       6977     6952      -25     
  Partials      364      364              
Files Changed Coverage Δ
pkg/remoting/loadbalance/xid_loadbalance.go 100.00% <100.00%> (+100.00%) ⬆️

@iSuperCoder iSuperCoder merged commit 97d6a39 into apache:master Aug 3, 2023
@slievrly slievrly added this to the 2.0.0 milestone Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

为remoting模块的xid_loadbalance编写单元测试
4 participants