[to-reply] feature: support saga multi type config #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaori-seasons
approved these changes
Dec 15, 2024
Code-Fight
requested changes
Dec 15, 2024
pkg/saga/statemachine/statelang/parser/statemachine_config_parser.go
Outdated
Show resolved
Hide resolved
pkg/saga/statemachine/statelang/parser/statemachine_config_parser.go
Outdated
Show resolved
Hide resolved
|
配置文件的解析，可以复用当前已有的逻辑 |
luky116
reviewed
Dec 15, 2024
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| _, err := parser.Parse(tt.configFilePath) |
luky116
reviewed
Dec 15, 2024
pkg/saga/statemachine/statelang/parser/statemachine_config_parser_test.go
Show resolved
Hide resolved
luky116
reviewed
Dec 15, 2024
|
apache License 要在你所有新增的文件上加上，只要没有的，都要加上 |
好的 |
xjlgod
reviewed
Dec 17, 2024
xjlgod
reviewed
Dec 17, 2024
luky116
changed the title
xjlgod
reviewed
Dec 22, 2024
pkg/saga/statemachine/statelang/parser/statemachine_json_parser.go
Outdated
Show resolved
Hide resolved
…ncubator-seata-go into feature-saga-multi-type-config
|
xjlgod
reviewed
Jan 15, 2025
| @@ -242,7 +259,7 @@ func (s ServiceTaskStateParser) Parse(stateName string, stateMap map[string]inte | |||
| return nil, err | |||
| } | |||
|
|
|||
| serviceName, err := s.GetString(stateName, stateMap, "serviceName") | |||
| serviceName, err := s.GetString(stateName, stateMap, "ServiceName") | |||
There was a problem hiding this comment.
During testing, I encountered errors, and upon investigation, I found that the key names in the three sets of test data in testdata/statelang were all "ServiceName" instead of "serviceName", as shown in the figure below. Therefore, I made the necessary modifications to pass the unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Supported multi-type configuration parser in saga mode, fixed some related problems, adjusted and improved related unit tests, and supplemented test data in yaml format.
Which issue(s) this PR fixes:
Fixes #734
Special notes for your reviewer:
All relevant unit tests have been completed and passed.
Does this PR introduce a user-facing change?: