optimize: undo log dirty throw BranchRollbackFailed_Unretriable #5051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caohdgege
reviewed
Nov 4, 2022
| */ | ||
| class SQLUndoDirtyException extends SQLException { | ||
|
|
||
| private static final long serialVersionUID = -5168905669539637570L; |
There was a problem hiding this comment.
都加了这个了，为什么不 implements Serializable
| if (e instanceof SQLUndoDirtyException) { | ||
| throw new BranchTransactionException(BranchRollbackFailed_Unretriable, | ||
| String.format( | ||
| "Branch session rollback failed because of dirty undo log. xid = %s branchId = %s %s", xid, |
There was a problem hiding this comment.
如果没意外的话，e.getMessage()就是上面的Has dirty records when undo.，跟前面的语义有点重复了
Codecov Report
@@ Coverage Diff @@
## develop #5051 +/- ##
=============================================
- Coverage 49.45% 49.41% -0.04%
+ Complexity 4125 4124 -1
=============================================
Files 733 734 +1
Lines 26049 26054 +5
Branches 3219 3220 +1
=============================================
- Hits 12882 12875 -7
- Misses 11791 11804 +13
+ Partials 1376 1375 -1
|
slievrly
reviewed
Nov 7, 2022
rm-datasource/src/main/java/io/seata/rm/datasource/undo/SQLUndoDirtyException.java
Outdated
Show resolved
Hide resolved
* '1103' of https://github.com/zw201913/seata: optimize: remove useless code (apache#5047) bugfix: fix startup failure of Server1.5.2 by using OpenJDK 11 (apache#4874) bugfix: insert value is all parsed as string in insert on duplicate (apache#5028) bugfix: global session is not change to Committed in saga mode (apache#5050)
funky-eyes
reviewed
Nov 7, 2022
| .format("Branch session rollback failed and try again later xid = %s branchId = %s %s", xid, | ||
| branchId, e.getMessage()), e); | ||
| if (e instanceof SQLUndoDirtyException) { | ||
| throw new BranchTransactionException(BranchRollbackFailed_Unretriable, |
funky-eyes
added
module/rm-datasource
funky-eyes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4997