optimize: compatible with integration-tx-api module and spring module #6342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xingfudeshi
changed the title
ok |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6342 +/- ##
============================================
- Coverage 51.94% 51.92% -0.03%
+ Complexity 5186 5183 -3
============================================
Files 921 921
Lines 32166 32166
Branches 3874 3874
============================================
- Hits 16709 16702 -7
- Misses 13821 13829 +8
+ Partials 1636 1635 -1
|
slievrly
reviewed
Feb 13, 2024
compatible/src/main/java/io/seata/integration/tx/api/interceptor/ActionContextUtil.java
Outdated
Show resolved
Hide resolved
slievrly
reviewed
Feb 13, 2024
compatible/src/main/java/io/seata/integration/tx/api/interceptor/ActionContextUtil.java
Outdated
Show resolved
Hide resolved
slievrly
reviewed
Feb 13, 2024
...a/io/seata/integration/tx/api/interceptor/handler/GlobalTransactionalInterceptorHandler.java
Outdated
Show resolved
Hide resolved
slievrly
reviewed
Feb 15, 2024
...a/io/seata/integration/tx/api/interceptor/handler/GlobalTransactionalInterceptorHandler.java
Show resolved
Hide resolved
slievrly
reviewed
Feb 15, 2024
compatible/src/main/java/io/seata/spring/annotation/GlobalTransactional.java
Show resolved
Hide resolved
slievrly
reviewed
Feb 15, 2024
compatible/src/main/java/io/seata/spring/annotation/GlobalTransactional.java
Show resolved
Hide resolved
slievrly
reviewed
Feb 15, 2024
compatible/src/main/java/io/seata/integration/tx/api/interceptor/ActionInterceptorHandler.java
Outdated
Show resolved
Hide resolved
slievrly
reviewed
Feb 15, 2024
compatible/src/main/java/io/seata/integration/tx/api/interceptor/ActionContextUtil.java
Outdated
Show resolved
Hide resolved
|
Ok.I got the point.Thank you! |
|
Done. @slievrly |
slievrly
changed the title
funky-eyes
reviewed
Feb 20, 2024
|
|
||
| import java.lang.reflect.Method; | ||
|
|
||
| public class GlobalTransactionalInterceptorParser extends org.apache.seata.integration.tx.api.interceptor.parser.GlobalTransactionalInterceptorParser { |
There was a problem hiding this comment.
Why didn't I find the spi file for org.apache.seata.integration.tx.api.interceptor.parser?
为什么我没找到org.apache.seata.integration.tx.api.interceptor.parser的spi文件？
There was a problem hiding this comment.
meta-inf/service/org.apache.seata.integration.tx.api.interceptor.parser.InterfaceParser
funky-eyes
reviewed
Feb 20, 2024
| } | ||
|
|
||
| GlobalLock lockAnnoOld = method.getAnnotation(GlobalLock.class); | ||
| org.apache.seata.spring.annotation.GlobalLock lockAnnoNew = method.getAnnotation(org.apache.seata.spring.annotation.GlobalLock.class); |
1 task
funky-eyes
added a commit
to funky-eyes/seata
that referenced
this pull request
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #6334
fixes #6335
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews