optimize: support instance registration to the registry center #7089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
added
module/discovery
slievrly
reviewed
Jan 3, 2025
| NetUtil.validAddress(address); | ||
| Instance instance = Instance.getInstance(); | ||
| instance.setTransaction(new Node.Endpoint(address.getAddress().getHostAddress(), address.getPort(), "netty")); | ||
| register(Instance.getInstance()); |
There was a problem hiding this comment.
The IP address should be checked to ensure that it is not a loopback address.
slievrly
reviewed
Jan 3, 2025
There was a problem hiding this comment.
https://github.com/apache/incubator-seata/pull/7089/files#diff-769bc40736ea7e87dd6b0dc2e3c5e04e5f1794d58dbf5e69aa21bb44082367baR161
Note that there may be vulnerabilities when deserializing, and the simple structure recommends serializing itself.
slievrly
reviewed
Jan 3, 2025
| @@ -170,9 +172,13 @@ public void initChannel(SocketChannel ch) { | |||
| try { | |||
| this.serverBootstrap.bind(port).sync(); | |||
| LOGGER.info("Server started, service listen port: {}", getListenPort()); | |||
| InetSocketAddress address = new InetSocketAddress(XID.getIpAddress(), XID.getPort()); | |||
| Instance instance = Instance.getInstance(); | |||
There was a problem hiding this comment.
I don't think it makes sense for Instance to be designed as a singleton.
slievrly
reviewed
Jan 3, 2025
| public class Instance { | ||
| private String namespace; | ||
| private String clusterName; | ||
| private String unit; | ||
| private Node.Endpoint control = new Node.Endpoint(); | ||
| private Node.Endpoint transaction = new Node.Endpoint(); | ||
| private Node.Endpoint control; |
There was a problem hiding this comment.
What is the specific meaning of Node.Endpoint control?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
support instance registration to the registry center
支持通过传递实例注册至注册中心，由于未来要扩展元数据，而先前注册时使用的InetSocketAddress入参已经不满足需求了，故进行修改为全局实例来满足该需求，后续可通过该实例中的metadata进行注册元数据至注册中心
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews