Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Imporve] Set required_approving_review_count to 2 #3764

Closed
wants to merge 1 commit into from
Closed

[Imporve] Set required_approving_review_count to 2 #3764

wants to merge 1 commit into from

Conversation

caicancai
Copy link
Member

What changes were proposed in this pull request

Issue Number: close #xxx

Brief change log

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): (yes / no)

@github-actions github-actions bot added the INFRA label Jun 16, 2024
@caicancai caicancai requested a review from wolfboys June 16, 2024 12:13
@wolfboys
Copy link
Member

hi caicancai:

Perhaps other projects already have such rules, but each project has its way of collaboration. Introducing rules is to solve problems and bring convenience, not to create obstacles. Currently, there are relatively few committers and PPMC members for Project StreamPark; these committers and PPMC members are not very active either. So I think it's not applicable now.

@caicancai caicancai closed this Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants