Fix time granularity-related issues #4821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4821 +/- ##
==========================================
+ Coverage 76.98% 77.01% +0.03%
==========================================
Files 44 44
Lines 8498 8501 +3
==========================================
+ Hits 6542 6547 +5
+ Misses 1956 1954 -2
Continue to review full report at Codecov.
|
|
Taking a look — thanks for fixing this! |
|
|
||
| For backward compatibility""" | ||
| d = {grain.duration: grain for grain in self.grains()} | ||
| d.update({grain.label: grain for grain in self.grains()}) |
There was a problem hiding this comment.
How do the grains show up in the form? Do we have duplicates?
There was a problem hiding this comment.
Looks ok. The dropdown uses the grains property, not grains_dict.
mistercrunch
force-pushed
the
fix_time_column
branch
from
bea6bd8 to
e460457
Compare
mistercrunch
force-pushed
the
fix_time_column
branch
from
e460457 to
98b372f
Compare
betodealmeida
approved these changes
Apr 18, 2018
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* Fixing time grain * Add tests
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
* Fixing time grain * Add tests
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Fixing time grain * Add tests
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #4755
@betodealmeida 👀