Fix regression in timestamp expression #4889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change to superset/connectors/sqla/models.py in #4821 introduced a regression, breaking time grain rendering.
|
Is this the fix for the % escaping? If so any chance you can add a test please? |
Codecov Report
@@ Coverage Diff @@
## master #4889 +/- ##
=======================================
Coverage 76.97% 76.97%
=======================================
Files 44 44
Lines 8537 8537
=======================================
Hits 6571 6571
Misses 1966 1966
Continue to review full report at Codecov.
|
|
No, unfortunately not, this effectively eliminated all grain rendering. Will try to look at those and related issues in the coming days (The Snowflake engine exhibits some funny behaviour that resembles the %-bug). |
|
Bug fixed in #4890 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to superset/connectors/sqla/models.py in #4821 introduced a regression, breaking time grain rendering.