[SIP-5] Refactor Chord vis

[kristw]

Decouple the visualization code from slice and formData

Test

Ran a development instance with the code above and verified with production instance that they produce the same results.

@williaster @conglei @graceguo-supercat

[codecov-io]

Codecov Report

Merging #5671 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #5671      +/-   ##
==========================================
- Coverage   63.51%   63.49%   -0.02%     
==========================================
  Files         360      360              
  Lines       22904    22911       +7     
  Branches     2551     2551              
==========================================
  Hits        14548    14548              
- Misses       8341     8348       +7     
  Partials       15       15

Impacted Files	Coverage Δ
superset/assets/src/visualizations/chord.jsx	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdd348a...8d44233. Read the comment docs.

[williaster]

wohoo! 🎉 this is the start of an amazing thing! 👯📈

overall looks great, a couple questions/thoughts:

• is it worth starting to define consistent data shapes with this decoupling? It might be too early for that but it seems potentially worthwhile to define/track the expected data shape (since you have the context of the vis fresh while doing this). we could define the data shape as a PropTypes.shape({ .. }) and then comment them out in the file until later.

• do you think we should move adapters to a separate file or directory? I'm a fan of small files for easy readability but again, it might be too early to start doing that/could just do in one PR later

[kristw]

Good idea with the data shape. I can start from defining propTypes for each chart.
Also a fan of small files, but let's keep that for another sweep PR, so each chart can be refactored independently without touching vizTypes and cause potential merge conflicts.

[williaster]

🔥 LGTM!

TIL that checkPropTypes exists :)