[INLONG-10208][Sort] ClsSink support unified configuration #10220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vernedeng
requested review from
fuweng11 and
luchunliang
and removed request for
fuweng11
fuweng11
reviewed
May 14, 2024
...t-standalone-source/src/main/java/org/apache/inlong/sort/standalone/sink/v2/SinkContext.java
Outdated
Show resolved
Hide resolved
...t-standalone-source/src/main/java/org/apache/inlong/sort/standalone/sink/v2/SinkContext.java
Outdated
Show resolved
Hide resolved
fuweng11
reviewed
May 14, 2024
...-source/src/main/java/org/apache/inlong/sort/standalone/source/sortsdk/v2/SortSdkSource.java
Show resolved
Hide resolved
...-source/src/main/java/org/apache/inlong/sort/standalone/source/sortsdk/v2/SortSdkSource.java
Outdated
Show resolved
Hide resolved
...-source/src/main/java/org/apache/inlong/sort/standalone/source/sortsdk/v2/SortSdkSource.java
Outdated
Show resolved
Hide resolved
...-source/src/main/java/org/apache/inlong/sort/standalone/source/sortsdk/v2/SortSdkSource.java
Outdated
Show resolved
Hide resolved
...-source/src/main/java/org/apache/inlong/sort/standalone/source/sortsdk/v2/SortSdkSource.java
Outdated
Show resolved
Hide resolved
...-source/src/main/java/org/apache/inlong/sort/standalone/source/sortsdk/v2/SortSdkSource.java
Outdated
Show resolved
Hide resolved
fuweng11
reviewed
May 14, 2024
...t-standalone-source/src/main/java/org/apache/inlong/sort/standalone/sink/v2/SinkContext.java
Show resolved
Hide resolved
fuweng11
previously approved these changes
May 15, 2024
luchunliang
reviewed
May 15, 2024
...sort-standalone-source/src/main/java/org/apache/inlong/sort/standalone/sink/cls/ClsSink.java
Outdated
Show resolved
Hide resolved
luchunliang
reviewed
May 15, 2024
...andalone-source/src/main/java/org/apache/inlong/sort/standalone/sink/cls/ClsSinkContext.java
Show resolved
Hide resolved
aloyszhang
reviewed
May 15, 2024
...-source/src/main/java/org/apache/inlong/sort/standalone/source/sortsdk/v2/SortSdkSource.java
Outdated
Show resolved
Hide resolved
3 tasks
aloyszhang
approved these changes
May 15, 2024
luchunliang
approved these changes
May 15, 2024
fuweng11
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10208
Motivation
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
(example:)
Documentation