Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-10526][Sort] ClsSink support switch metadata acquire mode #10539

Merged
merged 6 commits into from
Jul 1, 2024
Merged

[INLONG-10526][Sort] ClsSink support switch metadata acquire mode #10539

merged 6 commits into from
Jul 1, 2024

Conversation

vernedeng
Copy link
Contributor

Fixes #10526

Motivation

Modifications

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@vernedeng vernedeng self-assigned this Jun 30, 2024
vernedeng and others added 2 commits June 30, 2024 13:12
@XiaoYou201
Copy link
Contributor

LGTM～

luchunliang
luchunliang previously approved these changes Jun 30, 2024
View reviewed changes
@aloyszhang
Copy link
Contributor

Overall LGTM, just left a comment, PTAL.
And fix the failed unit test also.

@vernedeng vernedeng merged commit 8724e9e into apache:master Jul 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luchunliang luchunliang luchunliang approved these changes

@aloyszhang aloyszhang aloyszhang approved these changes

@fuweng11 fuweng11 Awaiting requested review from fuweng11

Assignees

@vernedeng vernedeng

Labels
component/manager component/sort
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improve][Sort] ClsSink support switch metadata acquire mode
4 participants
@vernedeng @XiaoYou201 @aloyszhang @luchunliang