Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-10675][SDK] Use exponential backoff instead of linear backoff retrying in Golang SDK #10678

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

gunli
Copy link
Contributor

@gunli gunli commented Jul 19, 2024

Fixes #10675

Motivation

Currently, when send batch failed, we just retry with a linear backoff, it is better to use a exponential backoff.

Modifications

  1. Use exponential backoff instead of linear backoff retrying.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@dockerzhang dockerzhang merged commit 8f03397 into apache:master Jul 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][SDK] Use exponential backoff instead of linear backoff retrying in Golang SDK
3 participants