Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-11687][Agent] Optimize task main thread exception handling to prevent exception exits #11688

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

justinwwhuang
Copy link
Contributor

@justinwwhuang justinwwhuang commented Jan 20, 2025

Fixes #11687

Motivation

Optimize task main thread exception handling to prevent exception exits

Modifications

Move the try statement inside the while loop

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

No doc needed

@dockerzhang dockerzhang merged commit 9abfce4 into apache:master Jan 20, 2025
11 checks passed
@justinwwhuang justinwwhuang deleted the b11687 branch January 20, 2025 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Agent] Optimize task main thread exception handling to prevent exception exits
3 participants