Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-11703][SDK] Improve the cleanExpiredConnTicker select logic in the connpool of the Golang SDK #11704

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

gunli
Copy link
Contributor

@gunli gunli commented Jan 22, 2025

Fixes #11703

Motivation

Refactor

Modifications

  1. rename connpool.recoverAndRebalance() to connpool.innerWork()
  2. use a select/case chan to replace the default case.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@vernedeng vernedeng merged commit 8cf5ed7 into apache:master Jan 22, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][SDK] Improve the cleanExpiredConnTicker select logic in the connpool of the Golang SDK
3 participants