Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-8671][Manager] Fix no method parameter of form data in POST request #8672

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

vernedeng
Copy link
Contributor

Prepare a Pull Request

Motivation

image Find no method parameter data iff the request is POST method and use x-www-form-urlencoded format.

This bug is due to the InlongRequestWrapper only parse the data in query string as the parameters.
But in HTTP standards, the x-www-form-urlencoded format with POST method request should parse the body as the parameters too.

Modifications

  1. Parse parameterMap as HTTP standard first.
  2. Adjust the order of parameter parsing and body parsing.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@dockerzhang dockerzhang merged commit 528dcf5 into apache:master Aug 9, 2023
ZhaoNiuniu pushed a commit to ZhaoNiuniu/inlong that referenced this pull request Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Manager] Find no method parameter of form data in POST request
4 participants