Load: convert to insert tablet on region replica set changes #14717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielWang2035
changed the title
DanielWang2035
commented
Feb 12, 2025
| @@ -273,6 +272,7 @@ public void start() { | |||
| final long startTime = System.nanoTime(); | |||
| try { | |||
| // if failed to load some TsFiles, then try to convert the TsFiles to Tablets | |||
| LOGGER.info("Load TsFile failed, will try to convert to tablets and insert."); | |||
There was a problem hiding this comment.
which tsfile
DanielWang2035
commented
Feb 12, 2025
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/StorageEngine.java
Show resolved
Hide resolved
DanielWang2035
commented
Feb 12, 2025
| String.format( | ||
| "No load TsFile uuid %s recorded for execute load command %s.", | ||
| uuid, loadCommand)); | ||
| if (!loadTsFileManager.loadAll(uuid, isGeneratedByPipe, progressIndex)) { |
DanielWang2035
commented
Feb 12, 2025
.../iotdb/db/storageengine/load/converter/LoadTreeStatementDataTypeConvertExecutionVisitor.java
Show resolved
Hide resolved
| final long startTime = System.nanoTime(); | ||
| try { | ||
| // if failed to load some TsFiles, then try to convert the TsFiles to Tablets | ||
| LOGGER.info( | ||
| "Load TsFile failed, will try to convert to tablets and insert. Failed TsFiles: [{}]", |
There was a problem hiding this comment.
Suggested change
| "Load TsFile failed, will try to convert to tablets and insert. Failed TsFiles: [{}]", | |
| "Load TsFile(s) failed, will try to convert to tablets and insert. Failed TsFiles: {}", |
| pieceNode.getTsFile(), | ||
| dataRegionId, | ||
| e); | ||
| status.setCode(TSStatusCode.INTERNAL_SERVER_ERROR.getStatusCode()); |
There was a problem hiding this comment.
Suggested change
| status.setCode(TSStatusCode.INTERNAL_SERVER_ERROR.getStatusCode()); | |
| status.setCode(TSStatusCode.LOAD_FILE_ERROR.getStatusCode()); |
SteveYurongSu
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.