James-4097 Allow disabling same-domain requirement when assigning rights #2573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibenwa
reviewed
Dec 19, 2024
| Ex in `jvm.properties` | ||
| ---- | ||
| james.rights.users.crossdomain=false |
There was a problem hiding this comment.
How about naming this
james.rights.crossdomain.allow=false
?
| @@ -74,6 +74,10 @@ public StoreRightManager(MailboxSessionMapperFactory mailboxSessionMapperFactory | |||
| this.eventBus = eventBus; | |||
| } | |||
|
|
|||
| private boolean isCrossDomainAccessAllowed() { | |||
| return Boolean.parseBoolean(System.getProperty("james.rights.users.crossdomain", "false")); | |||
There was a problem hiding this comment.
Make it a constant: looking this up at class loading is enough
There was a problem hiding this comment.
Ah ok I got it, that's needed because of the tests!
My suggestion is to allow the constant to be package local mutable annotated with @VisibleForTesting so that overloading that in tests become easy while keeping the property lookup at classloading time.
WDYT?
There was a problem hiding this comment.
I think that's a good idea 👍
mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreRightManager.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
James-4097
Add a configuration switch lifting the same-domain requirement when assigning rights.
This feature is opt-in - the default configuration will still forbid cross-domain access.