-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JAMES-3962 JMAP Email/set: move EmailHeader[]
from bodyValues
to htmlBody
/textBody
#2659
Conversation
...ts-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/EmailSetMethodContract.scala
Show resolved
Hide resolved
Good catch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this change be documented somewhere?
The James document is already similar to rfc8621 |
Yes but I meant more for clients using already jmap, if we move a field in the response? |
sorry, but I'm confused what should I do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for avoiding breaking change...
Add an entry in upgrade-instructions.md? |
Not sure, we only better conform to the RFC... |
…`htmlBody`/`textBody`
778dad3
to
5e873e9
Compare
rebase & squash |
Currently, the client sends a JSON request with
headers: EmailHeader[]
under thebodyValues
property, structured as follows:However, according to RFC 8621,

EmailBodyValue
does not reference headers property.Instead, headers are mentioned in the

EmailBodyPart
.The example in the RFC is also similar.
To align with the RFC specification, we need to update the mapping.
This change will also support cases where the email part uses
blobId
instead ofpartId
, while still allowing the client to set headers.