[SPARK][K8S] Support auto build Kubernetes client from env when Kyuubi running in Pod #3663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind:documentation
pan3793
reviewed
Oct 20, 2022
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/KubernetesApplicationOperation.scala
Outdated
Show resolved
Hide resolved
pan3793
reviewed
Oct 20, 2022
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/KubernetesApplicationOperation.scala
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #3663 +/- ##
============================================
+ Coverage 52.02% 52.42% +0.40%
Complexity 13 13
============================================
Files 485 490 +5
Lines 27202 27515 +313
Branches 3793 3816 +23
============================================
+ Hits 14151 14424 +273
- Misses 11685 11711 +26
- Partials 1366 1380 +14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pan3793
reviewed
Oct 21, 2022
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
Outdated
Show resolved
Hide resolved
pan3793
reviewed
Oct 21, 2022
pan3793
reviewed
Oct 21, 2022
kyuubi-server/src/main/scala/org/apache/kyuubi/util/KubernetesUtils.scala
Outdated
Show resolved
Hide resolved
pan3793
reviewed
Oct 21, 2022
kyuubi-server/src/main/scala/org/apache/kyuubi/util/KubernetesUtils.scala
Outdated
Show resolved
Hide resolved
5 tasks
pan3793
reviewed
Oct 23, 2022
kyuubi-server/src/main/scala/org/apache/kyuubi/util/KubernetesUtils.scala
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
kind:infra
pan3793
reviewed
Oct 24, 2022
zwangsheng
changed the title
|
I try my best to understand what you are trying to say about this PR in the PR desc, but failed |
This pr aims to add util object |
pan3793
changed the title
pan3793
approved these changes
Oct 25, 2022
|
refactor only change? |
pan3793
changed the title
|
The PR description is updated and should cover the changes in the PR. Thanks, merging to master |
|
The CI failure caused by known flaky tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Current kyuubi build kubernetes client for
KyuubiApplicationOperatorto find or kill spark engine on kubernetes.This pr aims to extract the code for building kubernetes client into
KubernetesUtilsand to do auto build following the logic in Spark.We prefer to building with user-configured parameters; When missing, the kubernetes client logic will build one from environment variables and kubeconfig.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request