Add resize node function for azure driver #1965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kami Can u take a look into this? |
Kami
approved these changes
Oct 28, 2023
Codecov Report
@@ Coverage Diff @@
## trunk #1965 +/- ##
=======================================
Coverage 83.19% 83.20%
=======================================
Files 353 353
Lines 81412 81423 +11
Branches 8591 8591
=======================================
+ Hits 67729 67740 +11
Misses 10875 10875
Partials 2808 2808
|
asfgit
pushed a commit
that referenced
this pull request
Oct 28, 2023
|
Merged into trunk. Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add resize node function for azure driver
Description
Background
#1964
To start with we have def ex_change_node_size(self, node, new_size) function in [https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/ec2.py] which supports instance type change for AWS.
We need similar functionality for Azure cloud as well where we could change the vmSize for Azure cloud. This could be done by adding node_resize function at (https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/azure_arm.py )
Implementation
ex_resize_nodeto change the azure vm instance type.test_resize_nodeto testex_resize_nodeStatus
Checklist (tick everything that applies)