added eu-west-3 AWS region #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added eu-west-3 (Paris) to the available AWS regions.
|
@keremdokuz Thanks for the contribution. Can you please fix failing lint checks? Besides that, change LGTM. |
Kami
reviewed
Apr 14, 2024
libcloud/storage/drivers/s3.py
Outdated
| @@ -1435,6 +1395,17 @@ class S3EUWest2StorageDriver(S3StorageDriver): | |||
| region_name = "eu-west-2" | |||
|
|
|||
|
|
|||
| class S3EUWest3Connection(S3SignatureV4Connection): | |||
There was a problem hiding this comment.
Those two classes are actually not needed anymore - this was an old approach (class per region) which is not used anymore and has been replaced via region class constructor argument.
Can you please remove them? Thanks.
There was a problem hiding this comment.
I removed them 🙂
Kami
approved these changes
Apr 15, 2024
|
Merged into trunk. Thanks. |
asfgit
pushed a commit
that referenced
this pull request
Apr 15, 2024
@Kami are you planning on a release in the near future? |
|
@keremdokuz We don't have a fixed release cadence, but if I get a chance, I will try to prepare a new release some time in the next couple of weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added eu-west-3 (Paris) to the available AWS regions.
Include a provider and a storage driver for the AWS region eu-west-3. This PR will allow working with data located in the eu-west-3 region of AWS using libcloud.
done, ready for review
Code linting (required, can be done after the PR checks)
Documentation
Tests
ICLA (required for bigger changes)