Clean up static config in SimpleLogger/StatusLogger #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Sicker <[email protected]>
|
I was kind of thinking of some sort of way to better represent this sort of property name to type map binding, though in the meantime, I figured I'd at least make the use of configuration beans more explicit. One idea I had was to support interfaces with annotations declaring the property name. The interface could be dynamically proxied to return data from the appropriate property environment. Alternatively, if there were a way to generate code from some annotated interfaces, then we could have compile-time proxies, too, to make it simpler to update how properties work for https://cwiki.apache.org/confluence/display/LOGGING/Properties+Enhancement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.