Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Either remove or fill this block of code #672

Closed
nikcio opened this issue Oct 15, 2022 · 2 comments · Fixed by #1032
Closed

Either remove or fill this block of code #672

nikcio opened this issue Oct 15, 2022 · 2 comments · Fixed by #1032
Assignees
@paulirwin
Labels
good-first-issue Good for newcomers hacktoberfest-accepted is:enhancement New feature or request up-for-grabs This issue is open to be worked on by anyone
Milestone
4.8.0-beta00018

Comments

@nikcio
Copy link
Contributor

nikcio commented Oct 15, 2022 •
edited
Loading

Mentioned in #648

Issues found: https://sonarcloud.io/project/issues?resolved=false&rules=csharpsquid%3AS108&id=apache_lucenenet

The comment associated with the line can be moved inside of the curly brackets to make it non-empty. If there is no comment, just add // LUCENNET: intentionally empty. Exception: empty finally blocks - we can remove the entire try/finally out of the methods in JavascriptLexer. Leave a comment // LUCENENET specific - removed unnecessary try/finally block in each method where they are removed.
@NightOwl888
Copy link
Contributor

Hmm...the SonarCloud link is not returning any results.

@NightOwl888 NightOwl888 added up-for-grabs This issue is open to be worked on by anyone good-first-issue Good for newcomers is:enhancement New feature or request hacktoberfest-accepted labels Oct 15, 2022
@nikcio
Copy link
Contributor Author

nikcio commented Oct 15, 2022

Should be fixed now

@paulirwin paulirwin added this to the 4.8.0-beta00018 milestone Oct 28, 2024
@paulirwin paulirwin self-assigned this Nov 19, 2024
paulirwin added a commit to paulirwin/lucene.net that referenced this issue Nov 19, 2024
@paulirwin
Add comments to empty blocks to address csharpsquid:S108, apache#672
8fcf09e
@paulirwin paulirwin mentioned this issue Nov 19, 2024
Merged
4 tasks
paulirwin added a commit that referenced this issue Nov 19, 2024
@paulirwin
Add comments to empty blocks to address csharpsquid:S108, #672 (#1032)
3c14b14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulirwin paulirwin

Labels
good-first-issue Good for newcomers hacktoberfest-accepted is:enhancement New feature or request up-for-grabs This issue is open to be worked on by anyone
Projects
None yet
Milestone
4.8.0-beta00018
Development

Successfully merging a pull request may close this issue.

Add comments to empty blocks to address Sonar csharpsquid:S108, #672 paulirwin/lucene.net
3 participants
@NightOwl888 @paulirwin @nikcio