Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'xxx' which hides the field with the same name #678

Closed
nikcio opened this issue Oct 15, 2022 · 1 comment · Fixed by #1042
Closed

Rename 'xxx' which hides the field with the same name #678

nikcio opened this issue Oct 15, 2022 · 1 comment · Fixed by #1042
Assignees
Labels
good-first-issue Good for newcomers hacktoberfest-accepted is:enhancement New feature or request up-for-grabs This issue is open to be worked on by anyone

Comments

@nikcio
Copy link
Contributor

nikcio commented Oct 15, 2022

Mentioned in #648

Issues found: https://sonarcloud.io/project/issues?resolved=false&rules=csharpsquid%3AS1117&id=apache_lucenenet

We can fix this for the static readonly fields. In regular instance methods, we should leave it alone unless it diverges from Lucene.

@NightOwl888 NightOwl888 added up-for-grabs This issue is open to be worked on by anyone good-first-issue Good for newcomers is:enhancement New feature or request hacktoberfest-accepted labels Oct 15, 2022
@paulirwin paulirwin added this to the 4.8.0-beta00018 milestone Oct 28, 2024
@paulirwin paulirwin self-assigned this Nov 19, 2024
@paulirwin
Copy link
Contributor

I reviewed all 206 of these issues, and of those, only 15 were ones we should fix. The remaining were the same as in Lucene, so we should not fix it as it is too risky, as noted in this original issue text. I've marked the 191 items we won't fix as "Accepted" with a reason of "Matches Lucene." After discussion with @NightOwl888, we feel this is preferable to littering our code with suppressions. The remaining I'll get a PR for.

paulirwin added a commit to paulirwin/lucene.net that referenced this issue Nov 21, 2024
paulirwin added a commit that referenced this issue Nov 21, 2024
… variable names (#1042)

* Fix csharpsquid:S1117 warnings about shadowing fields with variable names, #678
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Good for newcomers hacktoberfest-accepted is:enhancement New feature or request up-for-grabs This issue is open to be worked on by anyone
Projects
None yet
3 participants