Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Lucene.Net.Support.Arrays.Empty<T> with System.Array.Empty<T> #916

Closed
1 task done
paulirwin opened this issue Feb 24, 2024 · 0 comments · Fixed by #953
Closed
1 task done

Replace Lucene.Net.Support.Arrays.Empty<T> with System.Array.Empty<T> #916

paulirwin opened this issue Feb 24, 2024 · 0 comments · Fixed by #953
Labels
good-first-issue Good for newcomers is:task A chore to be done pri:low up-for-grabs This issue is open to be worked on by anyone

Comments

@paulirwin
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Task description

Since our minimum target is net462 which supports Array.Empty<T>() now, there is no longer any need for the Lucene.Net.Support.Arrays.Empty<T>() method and FEATURE_ARRAYEMPTY. We can replace all usages with Array.Empty<T>() and remove the Support method and EmptyArrayHolder<T> type.

cc @NightOwl888
@paulirwin paulirwin added the is:task A chore to be done label Feb 24, 2024
@paulirwin paulirwin mentioned this issue Feb 24, 2024
Merged
4 tasks
paulirwin added a commit to paulirwin/lucene.net that referenced this issue Feb 24, 2024
@paulirwin
Change Array.Empty<T> to Arrays.Empty<T> until apache#916 is done in …
e72dd6b 
…a separate PR
@NightOwl888 NightOwl888 added up-for-grabs This issue is open to be worked on by anyone good-first-issue Good for newcomers pri:low labels Mar 10, 2024
paulirwin added a commit that referenced this issue Mar 10, 2024
@paulirwin
Test review Core J-S, #259 (#914)
e08a342 
* Formatting and remove extraneous comment in Search/Payloads, #259

* Array formatting in Search/Similarities to match upstream

* Search/Spans formatting cleanup, use singletons for parameterless/captureless anonymous classes

* Code cleanup in Search/B-TestB tests

* Search/TestC code cleanup and allocation improvements

* Search/TestD-TestE code cleanup

* Test review TestF-TestL, #259

* Test review for rest of Search, #259

* Test review of Store, #259

* Finish J-S test cleanup

* Fix .NET FX build failure due to missing import

* Use CompareToOrdinal instead of string.Compare

* Change Array.Empty<T> to Arrays.Empty<T> until #916 is done in a separate PR

* Null-safe disposal of resources in TestSpansAdvanced

* Make TestSpansAdvanced.AssertHits static to match upstream Java code

* Use Arrays.Empty<T> in TestBoolean2 instead of Array.Empty<T>

* Revert static instance of MockScorer in TestCachingCollector

* Revert static instances of NoOpCollector in TestCachingCollector

* Fix seealso cref to CheckHits.CheckNoMatchExplanations

* Fix ticks math in RandomGen.LuceneDate

* Fix XML doc comment paragraph tag in TestFieldCacheRangeFilter

* Revert static instance of AnalyzerAnonymousClass in TestPhraseQuery

* Comment out TestScorerPerf.terms to prevent unused warning

* Remove use of Convert.ToInt32 which boxes in CheckHits

* Specify culture for Convert.ToInt32

* Fix spelling of TransactionalThreadInterrupt class

* Add back redundant override of TestRegexps in case some test runners don't report failures correctly

* Remove unused ConcurrentDictionaryWrapper type
J-Exodus added a commit to J-Exodus/lucenenet that referenced this issue Jul 25, 2024
@J-Exodus
Completed work for Issue apache#916
53a115e 
Removed ```Lucene.Net.Support.Arrays.Empty<T>()``` and ```FEATURE_ARRAYEMPTY```.
Converted all ```Arrays.Empty<T>()``` to ```Array.Empty<T>()``` and added ```using System;``` where required.
Removed ```using Lucene.Net.Support;``` statements that were no longer required.
@J-Exodus J-Exodus mentioned this issue Jul 25, 2024
Merged
J-Exodus added a commit to J-Exodus/lucenenet that referenced this issue Aug 13, 2024
@J-Exodus
Issue apache#916 - Rectified Pull Request Issues
08f695d 
Rectified Pull request issues as identified by NightOwl888:
 - Removed to missed references to `FEATURE_ARRAYEMPTY'
 - Reverted `FieldComparator.cs` back to original state
 - Corrected sort order for using statements
 - Reverted indentation on `JavascriptLexer.cs`
paulirwin pushed a commit that referenced this issue Aug 13, 2024
@J-Exodus
Completed work for Issue #916 - Conversion to native Array.Empty<T>() (…
09a6de9 
…#953)

* Completed work for Issue #916

Removed ```Lucene.Net.Support.Arrays.Empty<T>()``` and ```FEATURE_ARRAYEMPTY```.
Converted all ```Arrays.Empty<T>()``` to ```Array.Empty<T>()``` and added ```using System;``` where required.
Removed ```using Lucene.Net.Support;``` statements that were no longer required.

* Issue #916 - Rectified Pull Request Issues

Rectified Pull request issues as identified by NightOwl888:
 - Removed to missed references to `FEATURE_ARRAYEMPTY'
 - Reverted `FieldComparator.cs` back to original state
 - Corrected sort order for using statements
 - Reverted indentation on `JavascriptLexer.cs`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Good for newcomers is:task A chore to be done pri:low up-for-grabs This issue is open to be worked on by anyone
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Completed work for Issue #916 - Conversion to native Array.Empty<T>() J-Exodus/lucenenet
2 participants
@NightOwl888 @paulirwin