Deprecated support for Thread.Interrupt() #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…has already been removed.
…interruptableMonitor: Ignore tests that call Thread.Interrupt(), as this is not supportable in .NET. Closes apache#544.
…ported in Lucene.NET due to the high likelihood it could break a Commit() or cause a deadlock. Closes apache#526.
Open
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #526 and closes #544.
This PR just adds the [Ignore] attribute to the following tests and updates the
IndexWriterand directory documentation to indicate thatThread.Interrupt()is not supported in Lucene.NET due to the high possibility that it could break aCommit()or cause a deadlock.The code for
Thread.Interrupt()still exists in the codebase and we won't remove it, but it is just a best effort. Due to the fact that any code that we don't own that useslock ()orMonitor.Enter()could throwSystem.Threading.ThreadInterruptedExceptionin a part of the application where we don't expect it, it is not practical to support such a feature in .NET.