Remove unnecessary index writer getting opened #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NightOwl888 this is ready for the review. I was going to port the test changes, but that test is not there yet in our version and the AnalyzingInfixSuggester will undergo changes from the version we have to the version that's references in 2017 JIRA ticket. I am leaving the test out. I feel comfortable with our current test coverage for this class that we can proceed as is. |
NightOwl888
approved these changes
Apr 13, 2023
laimis
deleted the
fix/virtual-calls-from-constructors-analyzinginfixsuggester
branch
NightOwl888
added a commit
that referenced
this pull request
Apr 23, 2023
This reverts commit 8a7c112.
NightOwl888
added a commit
that referenced
this pull request
Apr 23, 2023
This reverts commit 8a7c112.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of fixes with virtual calls being made from constructors. The issue originally reported by SonarCloud scans: https://sonarcloud.io/project/issues?resolved=false&rules=csharpsquid%3AS1699&id=apache_lucenenet and referenced in this issue: #670
This one focuses on AnalyzingInfixSuggester. After going back to Lucene repository and looking at the history of the file, I found this:
https://issues.apache.org/jira/browse/LUCENE-7670
and apache/lucene@c1fe88b
The opening of a writer appears to be a bug that was fixed, and the line was removed. Removing the line eliminates the sonar cloud issue as well.