Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAHOUT-2216 [WIP] Delete Old Files that no longer exist in the "main" Branch #491

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

niallkp
Copy link
Contributor

@niallkp niallkp commented Jan 26, 2025

Purpose of PR:

Delete files that are out-of-date/un-maintained and include Google Analytics.

The following files moved to a new location

  • developers/buildingmahout.html
  • developers/developer-resources.html
  • developers/github.html
  • developers/githubPRs.html
  • developers/gsoc.html
  • developers/how-to-become-a-committer.html
  • developers/how-to-contribute.html
  • developers/how-to-release.html
  • developers/how-to-update-the-website.html
  • developers/issue-tracker.html
  • developers/patch-check-list.html
  • developers/thirdparty-dependencies.html
  • developers/version-control.html
  • general/downloads.html
  • general/mailing-lists.html
  • general/who-we-are.html

I believe the "minutes/2024/04/02/Meeting-Minutes.html" is a duplicate of "**minutes/2024/04/03/Meeting-Minutes.htm**l"

I can't find any equivalent file in the main branch for minutes/2024/04/02/Meeting-Minutes.html - you may want to recover this file and re-engineer a .md file to add to the main branch.

Important ToDos

Please mark each with an "x"

  • A JIRA ticket exists (if not, please create this first)[https://issues.apache.org/jira/browse/mahout/]
  • Title of PR is "MAHOUT-XXXX Brief Description of Changes" where XXXX is the JIRA number.
  • [ N/A] Created unit tests where appropriate
  • [ N/A] Added licenses correct on newly added files
  • Assigned JIRA to self
  • [N/A] Added documentation in scala docs/java docs, and to website
  • [N/A ] Successfully built and ran all unit tests, verified that all tests pass locally.

Does this change break earlier versions? No

Is this the beginning of a larger project for which a feature branch should be made? No

…main Branch. These files are out-of-date/un-maintained and include Google Analytics.

The following files moved to a new location
    - developers/buildingmahout.html
    - developers/developer-resources.html
    - developers/github.html
    - developers/githubPRs.html
    - developers/gsoc.html
    - developers/how-to-become-a-committer.html
    - developers/how-to-contribute.html
    - developers/how-to-release.html
    - developers/how-to-update-the-website.html
    - developers/issue-tracker.html
    - developers/patch-check-list.html
    - developers/thirdparty-dependencies.html
    - developers/version-control.html
    - general/downloads.html
    - general/mailing-lists.html
    - general/who-we-are.html

I believe the "minutes/2024/04/02/Meeting-Minutes.html" is a duplicate of "minutes/2024/04/03/Meeting-Minutes.html"

I can't find any equivalent file in the "main" branch for "minutes/2024/04/02/Meeting-Minutes.html" - you may want to recover this file and re-engineer a ".md" file to add to the main branch.
@rawkintrevo
Copy link
Contributor

Hiya @niallkp thanks again for the contribution! Could you speak more on what is going on here and #490 they seem to be related, but it's hard to see what happening in the githubUI. Further, they're both marked as WIP (and again, I can't really see what is going on, so I can't tell if it is or not). If it is WIP can you give a sentance or two about what is left, if it's not, could you drop that tag from title?

@niallkp
Copy link
Contributor Author

niallkp commented Jan 27, 2025

Hi Trevor,
Yes these two PRs are related - can you take a look at MAHOUT-2216 - I tried to explain the purpose of both there. But I'll put another explanation here, hopefully between the two it will make sense:

  • This PR #491 18 old "out-of-sync" files that are no longer being maintained. 16 of those files have moved to new locations. This PR fixes the main issue I want addressed which is they all contain Google Analytics.. But also, it gets rid of out-of-date pages from your website
  • The problem with just applying the this PR #491 is that you still have many links on your website pointing to these old pages, rather than the new locations where they've been moved to. So I've submitted PR #490 to fix these incorrect links

I marked this as WIP because it says if I couldn't tick all the questions in the checklist, then put WIP. I'll remove it

@niallkp
Copy link
Contributor Author

niallkp commented Jan 27, 2025

Heres some good examples of the wrong links. If you go to the /documentation/developers/index.html page, at the bottom of that page are a list of links that all point to old pages.

For example the How To Release link on that page points to /developers/how-to-release.html (old out-of-date page) instead of /documentation/developers/how-to-release.html (new in sync page).

So if I just submitted my PR to delete the old pages, your website would have a bunch of broken links - so I submitted a PR to fix those. Really that is an issue in itself that needs fixing - whether you get rid of the old pages or not

@rawkintrevo
Copy link
Contributor

Excellent, thanks so much @niallkp you're absolutely right- The site itself needs an overhaul, and is planned for later in feb. @andrewmusselman and I are going to do some deep surgery, as most of these pages are no longer relevant, just old bloat from prior versions of the project that are no longer relevant.

I'm ready to merge both of these, but does order matter?
You don't need to remove the WIP, but we appreciate you following the rules, i think you're the first person to ever do it 🥲

@niallkp
Copy link
Contributor Author

niallkp commented Jan 27, 2025

I don't think order matters too much, although I would fix the links first, then delete the old pages

@rawkintrevo rawkintrevo merged commit ded4c67 into apache:asf-site Jan 27, 2025
@rawkintrevo
Copy link
Contributor

thanks so much!!

@niallkp
Copy link
Contributor Author

niallkp commented Jan 27, 2025

You're welcome & Thank You @rawkintrevo for working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants