Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GIT protocol-v2 #429

Closed
pflaska opened this issue Nov 2, 2023 · 1 comment
Closed

Support GIT protocol-v2 #429

pflaska opened this issue Nov 2, 2023 · 1 comment
Labels
feature request A request for a new feature
Milestone
2.12.0

Comments

@pflaska
Copy link

pflaska commented Nov 2, 2023

Description

To make the git protocol-v2 work, the env. variable GIT_PROTOCOL has to be set to the 'version=2' value on the client side. The SSHD server reads the variable and sets extra parameters to use protocol v2.

Motivation

Git protocol v2 improves the v1 wire protocol in several ways and should be the preferred version.

Alternatives considered

No response

Additional context

protocol-v2 is supported by native git version >= 2.18.0 and jgit >= 5.11.

See https://git-scm.com/docs/protocol-v2/ for additional details.
pflaska pushed a commit to pflaska/mina-sshd that referenced this issue Nov 2, 2023
apacheGH-429: Support GIT protocol-v2
308ae8e 
Make the protocol-v2 default for client. GIT_PROTOCOL environment
variable is set to "version=2" in a session.

The UploadPack is modified to accept the variable.

apache#429
@pflaska pflaska mentioned this issue Nov 2, 2023
Closed
pflaska pushed a commit to pflaska/mina-sshd that referenced this issue Dec 5, 2023
apacheGH-429: GIT protocol-v2 on demand
f25d7f6 
Keep basic (unspecified) version of git protocol as the default.
The client must eplicitly request to use v2 protocol.
pflaska pushed a commit to pflaska/mina-sshd that referenced this issue Dec 11, 2023
apacheGH-429: Treat empty strings as null value
d9b4d75
lgoldstein pushed a commit to lgoldstein/mina-sshd that referenced this issue Dec 11, 2023
[apacheGH-429] Support GIT protocol-v2
8326025
lgoldstein pushed a commit to lgoldstein/mina-sshd that referenced this issue Dec 11, 2023
[apacheGH-429] Support GIT protocol-v2
a7fa5c1
asfgit pushed a commit that referenced this issue Dec 11, 2023
[GH-429] Support GIT protocol-v2
f5c63a8
@lgoldstein
Copy link
Contributor

Merged as 43288b58c7

@tomaswolf tomaswolf added this to the 2.12.0 milestone Dec 11, 2023
@tomaswolf tomaswolf added the feature request A request for a new feature label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request A request for a new feature
Projects
None yet
Milestone
2.12.0
Development

No branches or pull requests
3 participants
@lgoldstein @pflaska @tomaswolf