org.assertj:assertj-core dependency should have test scope

[cdivilly]

Version

2.14.0

Bug description

Even though the dependency for org.assertj:assertj-core is in the section labelled for test dependencies it does not have a <scope>test</scope> element, leading to it being treated as a compile scope dependency, which causes downstream depenencies to include org.assertj:assertj-core unecessarily.

        <dependency>
            <groupId>org.assertj</groupId>
            <artifactId>assertj-core</artifactId>
            <version>3.26.3</version>
        </dependency>

Actual behavior

org.assertj:assertj-core dependency is included by downstream dependencies of sshd-contrib, even though it is not used at runtime

        <dependency>
            <groupId>org.assertj</groupId>
            <artifactId>assertj-core</artifactId>
            <version>3.26.3</version>
        </dependency>

Expected behavior

org.assertj:assertj-core should have a <scope>test</scope> element so that it is only used at test time.

        <dependency>
            <groupId>org.assertj</groupId>
            <artifactId>assertj-core</artifactId>
            <version>3.26.3</version>
            <scope>test</scope>
        </dependency>

Relevant log output

Other information

No response

[tomaswolf]

Thanks for reporting; fixed.