-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Add more gluon computation test on MKLDNN with memory operation(s)(slice, reshape etc.) #10764
Conversation
@juliusshufan @piiswrong we cannot import mxnet in this test, as one of the unittests test if we can load mxnet properly. May be we could move that test to separate file. |
@piiswrong made changes here #10591 |
@ashokei Hi Ashok, if I hope keep these cases in same source file, I need to import the mxnet module for each case separately similar to the existing cases, right? If this is the right understanding, I'll make changes in next PR. Thanks. |
I think it is good idea to move the test_mkldnn_install to separate file, i made changes in #10591 . Your changes are ok. |
Good job @juliusshufan ! Thanks, @piiswrong for the review and merging. |
to be honest, i was a little surprised that the test is passed. i expect mkldnn conv doesn't work on an ndarray generated as a view of a MKLDNN NDArray (i.e., a slice from the mkldnn conv output). maybe we should take a little closer look at the C++ code how it works. |
I notice these tests seem to just use nchw. @juliusshufan i would consider using tensor shapes of (32,3,224,224), this would trigger mkldnn layout conversions. |
@ashokei Thanks for comments, I might take a trial and make amendment. |
Description
This PR introduces more test cases to cover the gluon computation on MKLDNN with ndarray related memory operations, such as slice, reshape etc. I am also implementing more test cases covering more gluon computations involving MKLDNN (such as BN, pooling etc.), and will be reflected in standalone PR(s) accordingly.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
All the changes is reflected by tests/python/mkl/test_mkldnn.py
Comments