Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Flaky Test] Fix test_gluon_model_zoo.test_models when MXNET_MKLDNN_DEBUG=1 #12069

Merged
merged 9 commits into from
Aug 14, 2018
Merged

[Flaky Test] Fix test_gluon_model_zoo.test_models when MXNET_MKLDNN_DEBUG=1 #12069

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d43e9c4
reorder inputs
azai91 Aug 7, 2018
9cf9fec
use function flatten vs build in method
azai91 Aug 7, 2018
8c797b3
update similar array atoi to 0.01
azai91 Aug 7, 2018
92c268b
fix reorder
azai91 Aug 7, 2018
db6f1cd
enable MXNET_MKLDNN_DEBUG in CI
azai91 Aug 8, 2018
d0a68c6
add exclude debug flag
azai91 Aug 9, 2018
eb04161
fix lint
azai91 Aug 9, 2018
4aaf82f
add warning log for excluded op
azai91 Aug 12, 2018
3e635d7
retrigger
azai91 Aug 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/operator/nn/mkldnn/mkldnn_base.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,11 +496,8 @@ void OpCheck::Run(mxnet::FCompute fn, const nnvm::NodeAttrs &attrs,
const std::vector<mxnet::NDArray> &inputs_,
const std::vector<mxnet::OpReqType> &req,
const std::vector<mxnet::NDArray> &outputs_) {

static auto& is_excluded = Op::GetAttr<bool>("TExcludeMKLDNNDebug");

if (is_excluded.get(attrs.op, false)) return;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we give a warning that the OP is not checked?

std::vector<mxnet::TBlob> in_blobs(inputs.size());
for (size_t i = 0; i < in_blobs.size(); i++) in_blobs[i] = inputs[i].data();
std::vector<mxnet::TBlob> out_blobs(outputs.size());
Expand Down