Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-703] Fix relative import in TensorRT #12122

Closed
wants to merge 44 commits into from
Closed

[MXNET-703] Fix relative import in TensorRT #12122

wants to merge 44 commits into from

Conversation

KellenSunderland
Copy link
Contributor

@KellenSunderland KellenSunderland commented Aug 10, 2018 •
edited
Loading

Description

Fix relative import in TensorRT

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Not please do not merge this until #11325 is merged.

Marek Kolodziej and others added 30 commits July 26, 2018 16:59
@Caenorst @KellenSunderland
[MXNET-703] TensorRT runtime integration
268e90b 
Co-authored-by: Clement Fuji-Tsang <[email protected]>
Co-authored-by: Kellen Sunderland <[email protected]>
@Caenorst
correctly assign self._optimized_symbol in executor
4855d8a
@Caenorst
declare GetTrtCompatibleSubsets and ReplaceSubgraph only if MXNET_USE…
419b294 
…_TENSORRT
@Caenorst
add comments in ReplaceSubgraph
8d723c9
Addressing Haibin's code review points
ca94624
Check that shared_buffer is not empty when USE_TENSORRT is set
75c8642
Added check that TensorRT binding is for inference only
2a11466
@mkolod
Removed redundant decl.
190c9bf
@KellenSunderland
WIP Refactored TRT integration and tests
d88ad8b
@KellenSunderland
Add more build guards, remove unused code
87ebdce
@KellenSunderland
Remove ccache report
83fa475
@KellenSunderland
Remove redundant const in declaration
4a3772f
@KellenSunderland
Clean Cmake TRT files
f779537
@KellenSunderland
Remove TensorRT env var usage
b0748ef 
We don't want to use environment variables with TensorRT yet, the
logic being that we want to try and have as much fwd compatiblity as
possible when working on an experimental feature.  Were we to add
env vars they would have to be gaurenteed to work in the future until
a major version change.  Moving the functionality to a contrib call
reduces this risk.
@KellenSunderland
Use contrib optimize_graph instaed of bind
35e1367
@KellenSunderland
Clean up cycle detector
6338e45
@KellenSunderland
Convert lenet test to contrib optimize
21d0239
@KellenSunderland
Protect interface with trt build flag
f30dbef
@KellenSunderland
Fix whitespace issues
eaba593
@KellenSunderland
Add another build guard to c_api
f870a3f
@KellenSunderland
Move get_optimized_symbol to contrib area
e40d6b3
@KellenSunderland
Ignore gz files in test folder
7fa6a4a
@KellenSunderland
Make trt optimization implicit
e777ab5
@KellenSunderland
Remove unused declaration
3ea9b89
@KellenSunderland
Replace build guards with runtime errors
d6d2cac
@KellenSunderland
Change default value of TensorRT to off
2d04aee 
This is change applies to both TensorRT and non-TensorRT builds.
@KellenSunderland
Warn user when TRT not active at runtime
449a195
@KellenSunderland
Move TensorRTBind declaration, add descriptive errors
ed36739
@KellenSunderland
Test TensorRT graph execution, fix bugs
882d8e5
@KellenSunderland
Fix lint and whitespace issues
95a7955
@marcoabreu
Copy link
Contributor

Could you rebase please

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anirudh2290 anirudh2290 Awaiting requested review from anirudh2290

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KellenSunderland @marcoabreu @Caenorst @mkolod