This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
fix for params with no dims in onnx #13413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wangxinanbook added a fix for the issue in this PR as this issue came while running a model without dims value in params. |
Roshrini
changed the title
|
@mxnet-label-bot add [pr-awaiting-review, ONNX] |
vandanavk
reviewed
Nov 28, 2018
| np_array = to_array(tensor_proto).reshape(tuple(tensor_proto.dims)) | ||
| else: | ||
| np_array = np.array([to_array(tensor_proto)]) | ||
| return nd.array(np_array) |
There was a problem hiding this comment.
this line should be outside the else
Roshrini
force-pushed
the
no_dims_params
branch
2 times, most recently
from
da32f75 to
17b14f0
Compare
|
do you think it makes sense to add a unit test for this case? |
Roshrini
force-pushed
the
no_dims_params
branch
from
17b14f0 to
8eb1ba5
Compare
|
@nswamy Added test case |
Codecov Report
@@ Coverage Diff @@
## master #13413 +/- ##
==========================================
- Coverage 83.27% 81.24% -2.04%
==========================================
Files 722 724 +2
Lines 79010 80525 +1515
Branches 3223 3229 +6
==========================================
- Hits 65796 65420 -376
- Misses 12344 14232 +1888
- Partials 870 873 +3
Continue to review full report at Codecov.
|
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* fix for params with no dims * fix * fix * retrigger build * test added * retrigger CI * retrigger ci
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
input tensor_proto can be a numeric variable and sometimes it can have tensor_proto.dims parameter empty. In this case, as the shape cannot be infered, and reshape will throw an error. Adding a fix for it
Fixes #13300
@thomelane @vandanavk
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.