Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[WIP] Make image Resize, CeterCrop, and RandomResizedCrop as operator #13483

Closed
wants to merge 97 commits into from
Closed

[WIP] Make image Resize, CeterCrop, and RandomResizedCrop as operator #13483

wants to merge 97 commits into from

Conversation

stu1130
Copy link
Contributor

@stu1130 stu1130 commented Nov 30, 2018

Description

Make image resize as operator
wait for #13357 to add unit test and refactor the image related test cases

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Comments

@stu1130
Merge branch 'master' of https://github.com/apache/incubator-mxnet
a9d40c4
@stu1130
Merge branch 'master' of https://github.com/apache/incubator-mxnet
429684a
@stu1130
Merge branch 'master' of https://github.com/apache/incubator-mxnet
602b7d0
@stu1130
Merge branch 'master' of https://github.com/apache/incubator-mxnet
85f9408
@stu1130
Merge branch 'master' of https://github.com/apache/incubator-mxnet
5a01234
@stu1130
Merge branch 'master' of https://github.com/apache/incubator-mxnet
8f58746
@stu1130
Merge branch 'master' of https://github.com/apache/incubator-mxnet
1531594
@stu1130
Merge branch 'master' of https://github.com/apache/incubator-mxnet
3e799de
@stu1130
Merge branch 'master' of https://github.com/apache/incubator-mxnet
f690c69
@stu1130
Merge branch 'master' of https://github.com/apache/incubator-mxnet
a091a97
@stu1130
Merge branch 'master' of https://github.com/apache/incubator-mxnet
f1359be
@stu1130
Merge branch 'master' of https://github.com/apache/incubator-mxnet
e360853
@stu1130
Merge branch 'master' of https://github.com/apache/incubator-mxnet
23199d1
@stu1130
Merge branch 'master' of https://github.com/apache/incubator-mxnet
166c2b6
@stu1130
Merge branch 'master' of https://github.com/apache/incubator-mxnet
d01e8cb
@stu1130
Merge branch 'master' of https://github.com/apache/incubator-mxnet
0454017
@stu1130
Merge branch 'master' of https://github.com/apache/incubator-mxnet
90f1dd8
@stu1130
make resize as a operator
93b5a10
@stu1130
change the calculation of ResizeShape
9cb7f8b
@stu1130
Merge branch 'master' of https://github.com/apache/incubator-mxnet
2f019cd
@stu1130
add uncomplete unit test to debug with VSCode
2e3aa6f
@stu1130
use hybrid_forward instead of forward
d4a65ce
@stu1130
add resize operator
b0ec3ca
@stu1130
Merge branch 'master' of https://github.com/apache/incubator-mxnet
ec075f5
@stu1130
Merge branch 'master' into add_resize_crop_image_operator
297e638
@stu1130
Merge branch 'master' of https://github.com/apache/incubator-mxnet
d5cdb89
@stu1130
use tuple to fix the python c++ conversion
1189640
@stu1130
fix the logic error
fc12983
@stu1130
delete inline function to minimize binary file size
bc731b0
@stu1130
use hybrid_forward
dbca6ae
@stu1130 stu1130 changed the title [WIP] Make image resize as operator [WIP] Make image Resize, CeterCrop, and RandomResizedCrop as operator Dec 6, 2018
ChaiBapchya and others added 22 commits December 5, 2018 21:58
@ChaiBapchya @aaronmarkham
Updated docs for randint operator (apache#13541)
e0ff3c3 
* updated docs for randint

* added randint in __all__ and reordered acc to categorical then alphabetical

* Trigger CI

* minus mxnet.symbol and alphabetical for ndarray,symbol.md

* alphabetical order
@ChaiBapchya @yzhliu
Chi_square_check for discrete distribution fix (apache#13543)
cf6e8cb 
* check for bucket instead of index

* enumerate instead of range(len())

* count instead of sum to solve attribute error

* revert to sum

* seperate discrete and continuous

* Trigger CI
@TaoLv
Revert "Bumped minor version from 1.4.0 to 1.5.0 on master, updated L…
29885c5 
…icense file" (apache#13558)

* Revert "Chi_square_check for discrete distribution fix (apache#13543)"

This reverts commit cf6e8cb.

* Revert "Updated docs for randint operator (apache#13541)"

This reverts commit e0ff3c3.

* Revert "Simplifications and some fun stuff for the MNIST Gluon tutorial (apache#13094)"

This reverts commit 8bbac82.

* Revert "Fix apache#13521 (apache#13537)"

This reverts commit f6b4665.

* Revert "Add a retry to qemu_provision (apache#13551)"

This reverts commit f6f8401.

* Revert "[MXNET-769] Use MXNET_HOME in a tempdir in windows to prevent access denied due t… (apache#13531)"

This reverts commit bd8e0f8.

* Revert "[MXNET-1249] Fix Object Detector Performance with GPU (apache#13522)"

This reverts commit 1c8972c.

* Revert "Fixing a 404 in the ubuntu setup doc (apache#13542)"

This reverts commit cb0db29.

* Revert "Bumped minor version from 1.4.0 to 1.5.0 on master, updated License file (apache#13478)"

This reverts commit 40db619.
@hellonico @gigasquid
apache#13441 [Clojure] Add Spec Validations for the Random namespace (…
8feb826 
…apache#13523)
@stu1130
Merge branch 'master' of https://github.com/stu1130/incubator-mxnet
a26771d
@stu1130
make resize as a operator
6a6040e
@stu1130
change the calculation of ResizeShape
e5e8849
@stu1130
add uncomplete unit test to debug with VSCode
acbbf96
@stu1130
use hybrid_forward instead of forward
326843a
@stu1130
add resize operator
985bfda
@stu1130
use tuple to fix the python c++ conversion
1cfe253
@stu1130
fix the logic error
3b5d3bc
@stu1130
delete inline function to minimize binary file size
bc1cddd
@stu1130
use hybrid_forward
cc2aa1b
@stu1130
remove the test case for now and add missing inline
5a4b4d7
@stu1130
remove import unittest
ed6f982
@stu1130
fix linter and refactor the include order
b3d2e04
@stu1130
only include opencv header if build with opencv
27f3b9c
@stu1130
add centercrop operator
d92e85b
@stu1130
add centercrop
85102a9
@stu1130
comment the random_resize_crop
63ea1d3
@stu1130
Merge branch 'add_resize_crop_image_operator' of https://github.com/s…
ade591f 
…tu1130/incubator-mxnet into add_resize_crop_image_operator

# Conflicts:
#	src/operator/image/image_random-inl.h
#	src/operator/image/image_random.cc
@stu1130 stu1130 closed this Dec 6, 2018
@stu1130 stu1130 deleted the add_resize_crop_image_operator branch December 6, 2018 19:37
@stu1130 stu1130 restored the add_resize_crop_image_operator branch December 11, 2018 05:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anirudh2290 anirudh2290 Awaiting requested review from anirudh2290

@szha szha Awaiting requested review from szha szha is a code owner

@gigasquid gigasquid Awaiting requested review from gigasquid gigasquid is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

@nswamy nswamy Awaiting requested review from nswamy nswamy is a code owner

@yzhliu yzhliu Awaiting requested review from yzhliu yzhliu is a code owner

Assignees
No one assigned
Labels
Operator pr-work-in-progress PR is still work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.