[MXNET-1291] solve pylint errors in examples with issue no.12205 #13815

cchung100m · 2019-01-09T14:52:39Z

Description

solve pylint errors in examples with issue #12205

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
Changes are complete (i.e. I finished coding on this PR)
All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Feature1, tests, (and when applicable, API doc)
Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

cchung100m · 2019-01-09T16:06:58Z

I will open PR after finishing all parts of commits

anirudhacharya · 2019-01-10T19:22:05Z

@mxnet-label-bot add [pr-awaiting-review]

@vandanavk for review

vandanavk · 2019-01-11T21:06:53Z

the changes LGTM. could you fix the conflict - example/bayesian-methods/bdk_demo.py?

cchung100m · 2019-01-17T01:07:42Z

@vandanavk

the changes LGTM. could you fix the conflict - example/bayesian-methods/bdk_demo.py?

I solve the conflict of bdk_demo.py and re-trigger the CI. thank you for the suggestions. :)

vandanavk · 2019-01-27T01:39:57Z

@sandeep-krishnamurthy for review

cchung100m · 2019-02-01T09:23:26Z

Hi @marcoabreu ,

Sorry for asking a rookie problem, how to re-trigger the failed job from Jenkins except commit another change of files.

Best regards,

marcoabreu · 2019-02-01T09:24:47Z

You can use git commit --allow-empty :) Am Fr., 1. Feb. 2019, 10:23 hat Neil Chien <[email protected]> geschrieben:

…

Hi @marcoabreu <https://github.com/marcoabreu> , Sorry for asking a rookie problem, how to re-trigger the failed job from Jenkins except commit another change of files. Best regards, — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13815 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ARxB69oX-n30PGv8-OdnUNJQlbvVyp1Oks5vJAetgaJpZM4Z3o9M> .

cchung100m · 2019-02-01T09:31:48Z

@marcoabreu ,

Thanks for the prompt reply. You make me a great progress on participating open source community. (laugh) Thanks again.

Best regards,

Unify the style here and remove the testing 'print' code segment.

Change the description of comment from "multi-layer perceptron" to "Get multi-layer perceptron"

@sandeep-krishnamurthy

Unify the style of comments suggested by @sandeep-krishnamurthy

Sovle example/deep-embedded-clustering/solver.py(150): [C0304 ] Final newline missing

cchung100m · 2019-02-10T13:58:08Z

Hi @sandeep-krishnamurthy @marcoabreu

I complete the rebase and re-test, I will appreciate if you can help to review/merge, thanks.

sandeep-krishnamurthy

Thank you @cchung100m for all your contributions!
LGTM
Can be merged after CI test passes.

cchung100m · 2019-02-11T00:31:58Z

Hi @sandeep-krishnamurthy

Thanks for the prompt reply, and CI test passes.

@sandeep-krishnamurthy

…che#13815) * Unify the style here Unify the style here and remove the testing 'print' code segment. * Unify the description of comment Change the description of comment from "multi-layer perceptron" to "Get multi-layer perceptron" * Unify the style of comments Unify the style of comments suggested by @sandeep-krishnamurthy * git pull the lastest code from master of incubator-mxnet * Complete rebase * Solve PEP8 [C0304 ] Final newline missing Sovle example/deep-embedded-clustering/solver.py(150): [C0304 ] Final newline missing

@sandeep-krishnamurthy

…che#13815) * Unify the style here Unify the style here and remove the testing 'print' code segment. * Unify the description of comment Change the description of comment from "multi-layer perceptron" to "Get multi-layer perceptron" * Unify the style of comments Unify the style of comments suggested by @sandeep-krishnamurthy * git pull the lastest code from master of incubator-mxnet * Complete rebase * Solve PEP8 [C0304 ] Final newline missing Sovle example/deep-embedded-clustering/solver.py(150): [C0304 ] Final newline missing

@sandeep-krishnamurthy

…che#13815) * Unify the style here Unify the style here and remove the testing 'print' code segment. * Unify the description of comment Change the description of comment from "multi-layer perceptron" to "Get multi-layer perceptron" * Unify the style of comments Unify the style of comments suggested by @sandeep-krishnamurthy * git pull the lastest code from master of incubator-mxnet * Complete rebase * Solve PEP8 [C0304 ] Final newline missing Sovle example/deep-embedded-clustering/solver.py(150): [C0304 ] Final newline missing

@sandeep-krishnamurthy

…che#13815) * Unify the style here Unify the style here and remove the testing 'print' code segment. * Unify the description of comment Change the description of comment from "multi-layer perceptron" to "Get multi-layer perceptron" * Unify the style of comments Unify the style of comments suggested by @sandeep-krishnamurthy * git pull the lastest code from master of incubator-mxnet * Complete rebase * Solve PEP8 [C0304 ] Final newline missing Sovle example/deep-embedded-clustering/solver.py(150): [C0304 ] Final newline missing

@sandeep-krishnamurthy

…che#13815) * Unify the style here Unify the style here and remove the testing 'print' code segment. * Unify the description of comment Change the description of comment from "multi-layer perceptron" to "Get multi-layer perceptron" * Unify the style of comments Unify the style of comments suggested by @sandeep-krishnamurthy * git pull the lastest code from master of incubator-mxnet * Complete rebase * Solve PEP8 [C0304 ] Final newline missing Sovle example/deep-embedded-clustering/solver.py(150): [C0304 ] Final newline missing

cchung100m requested a review from szha as a code owner January 9, 2019 14:52

cchung100m closed this Jan 9, 2019

cchung100m changed the title ~~[issue_12205 - PART1] solve pylint errors in examples with issue no.12205~~ [MXNET-1291] solve pylint errors in examples with issue no.12205 Jan 10, 2019

cchung100m reopened this Jan 10, 2019

marcoabreu added the pr-awaiting-review PR is waiting for code review label Jan 10, 2019

cchung100m mentioned this pull request Jan 11, 2019

Lint errors in examples #12205

Open

vandanavk approved these changes Jan 22, 2019

View reviewed changes

cchung100m added 5 commits February 10, 2019 21:38

git pull the lastest code from master of incubator-mxnet

83c3489

Unify the style here

ed91e2c

Unify the style here and remove the testing 'print' code segment.

Unify the description of comment

454aaca

Change the description of comment from "multi-layer perceptron" to "Get multi-layer perceptron"

Unify the style of comments

df9b905

Unify the style of comments suggested by @sandeep-krishnamurthy

Complete rebase

b928376

cchung100m force-pushed the issue12205_2 branch from 6a90a19 to b928376 Compare February 10, 2019 13:41

Solve PEP8 [C0304 ] Final newline missing

d855aba

Sovle example/deep-embedded-clustering/solver.py(150): [C0304 ] Final newline missing

sandeep-krishnamurthy approved these changes Feb 10, 2019

View reviewed changes

sandeep-krishnamurthy added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-review PR is waiting for code review labels Feb 10, 2019

sandeep-krishnamurthy merged commit 0a2419f into apache:master Feb 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MXNET-1291] solve pylint errors in examples with issue no.12205 #13815

[MXNET-1291] solve pylint errors in examples with issue no.12205 #13815

cchung100m commented Jan 9, 2019 •

edited

Loading

cchung100m commented Jan 9, 2019

anirudhacharya commented Jan 10, 2019

vandanavk commented Jan 11, 2019

cchung100m commented Jan 17, 2019 •

edited

Loading

vandanavk commented Jan 27, 2019

cchung100m commented Feb 1, 2019

marcoabreu commented Feb 1, 2019 via email

cchung100m commented Feb 1, 2019

cchung100m commented Feb 10, 2019

sandeep-krishnamurthy left a comment

cchung100m commented Feb 11, 2019

[MXNET-1291] solve pylint errors in examples with issue no.12205 #13815

[MXNET-1291] solve pylint errors in examples with issue no.12205 #13815

Conversation

cchung100m commented Jan 9, 2019 • edited Loading

Description

Checklist

Essentials

Changes

Comments

cchung100m commented Jan 9, 2019

anirudhacharya commented Jan 10, 2019

vandanavk commented Jan 11, 2019

cchung100m commented Jan 17, 2019 • edited Loading

vandanavk commented Jan 27, 2019

cchung100m commented Feb 1, 2019

marcoabreu commented Feb 1, 2019 via email

cchung100m commented Feb 1, 2019

cchung100m commented Feb 10, 2019

sandeep-krishnamurthy left a comment

Choose a reason for hiding this comment

cchung100m commented Feb 11, 2019

cchung100m commented Jan 9, 2019 •

edited

Loading

cchung100m commented Jan 17, 2019 •

edited

Loading