This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fix symbolic example for rand_zipfian function #13855
Closed
+2
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mxnet-label-bot add [pr-awaiting-review] |
|
LGTM but I can't tell what's fixed. Were the values reported in the docs wrong? |
|
The example before had NDArray. I replaced it with a corresponding Symbolic example |
|
@mxnet-label-bot update [pr-awaiting-review] |
marcoabreu
added
pr-awaiting-merge
|
Gotcha. Lgtm. |
KellenSunderland
approved these changes
Jan 18, 2019
|
@safrooze @ThomasDelteil Do you mind considering my PR since I had discovered it before and made PR as well? |
|
Never mind. Other PR #13978 Got merged into the repo (despite being a duplicate of this PR). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mx.sym.contrib.rand_zipfianfunction example fixedIt contained NDArray specific example for a Symbolic API