This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[MXNET-1383] Java new use of ParamObject #14645
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachgk
reviewed
Apr 8, 2019
@@ -86,15 +86,15 @@ public void testGenerated(){ | |||
NDArray$ NDArray = NDArray$.MODULE$; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you still need this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it didn't save the world of the method likeNDArray.<method_name>
popping out
scala-package/macros/src/main/scala/org/apache/mxnet/APIDocGenerator.scala
Outdated
Show resolved
Hide resolved
@frankfliu here as well |
Roshrini
added
pr-awaiting-review
PR is waiting for code review
Java
Label to identify Java API component
labels
Apr 16, 2019
@frankfliu Can you help review? |
lanking520
force-pushed
the
java-paramObj
branch
2 times, most recently
from
April 25, 2019 17:58
60aa9b5
to
cc01350
Compare
lanking520
force-pushed
the
java-paramObj
branch
from
April 25, 2019 18:14
cc01350
to
b66fc86
Compare
yzhliu
approved these changes
Apr 27, 2019
lanking520
added a commit
to lanking520/incubator-mxnet
that referenced
this pull request
Apr 29, 2019
lanking520
added a commit
that referenced
this pull request
Apr 29, 2019
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
May 14, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously paramObj are created in a weird way. This is a fix to that:
NDArray.new paramObj
->new paramObj
The trick is to put these param classes outside of NDArray Base and it made it accessible to the public directly under
org.apache.mxnet.javaapi
@andrewfayres @zachgk @yzhliu @nswamy
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.