-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[MXNET-1287] Fix test memory with ResourceScope #14666
Conversation
@mxnet-label-bot add [Scala, pr-awaiting-review] |
Try to clean up this: All the rest LGTM |
This PR now removes all usages of NDArrayCollector throughout the code. It also officially deprecates it as of 1.5. I also improved the ResourceScope to recursively move NDArrays to outer scope when in hierarchical structure of Traversables (list, set, map, etc.) and Products (tuples). |
@zachgk can you please move this to a separate PR along with tests for this change?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this.
Please create a separate PR for modifying the MoveToOuterScope along with tests.
@nswamy is this PR good to go? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@nswamy I believe this one is good to go. Please take a look |
Description
Adds ResourceScope to various tests to avoid memory leaks. Otherwise, it is possible to run out of memory on smaller machines. Contains a part of #13995.
@lanking520 @andrewfayres
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.