Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.4.x] Backport flaky test layer bidirectional fix #14908

Merged

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented May 7, 2019

Description

Backports flaky test_gluon_rnn.test_layer_bidirectional fix from PR #14682 (see #13103). Ensures tests aren't flaky against over versions of CUDA, as per the issue.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Just updates the tolerances for the specified test.

Comments

@vandanavk
Copy link
Contributor

@mxnet-label-bot add [pr-awaiting-review, Flaky, Test]

@perdasilva could you include the PR description template and fill in details

@marcoabreu marcoabreu added Flaky pr-awaiting-review PR is waiting for code review Test labels May 7, 2019
@szha szha merged commit e7fe640 into apache:v1.4.x May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Flaky pr-awaiting-review PR is waiting for code review Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants