This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test? |
@marcoabreu I really want to have a test for this, but from the bug report #15555 you will know that the test will be quite complicated, and not stable. It's an thread race issue, so even if this test is broken someday, it will look like a flaky test(sometime pass and sometime fail), which doesn't help to capture the trouble PR. If you still want to have that kind of test, I can add the reported case as a test. |
Ok, feel free to go ahead. |
Thanks for your contribution. Merging now. |
juliusshufan
pushed a commit
to juliusshufan/incubator-mxnet
that referenced
this pull request
Aug 8, 2019
* Fix _copy_to * Add comment
juliusshufan
pushed a commit
to juliusshufan/incubator-mxnet
that referenced
this pull request
Aug 8, 2019
* Fix _copy_to * Add comment
juliusshufan
pushed a commit
to juliusshufan/incubator-mxnet
that referenced
this pull request
Aug 11, 2019
* Fix _copy_to * Add comment
juliusshufan
pushed a commit
to juliusshufan/incubator-mxnet
that referenced
this pull request
Aug 11, 2019
* Fix _copy_to * Add comment
juliusshufan
pushed a commit
to juliusshufan/incubator-mxnet
that referenced
this pull request
Aug 12, 2019
* Fix _copy_to * Add comment
anirudhacharya
pushed a commit
to anirudhacharya/mxnet
that referenced
this pull request
Aug 20, 2019
* Fix _copy_to * Add comment
juliusshufan
pushed a commit
to juliusshufan/incubator-mxnet
that referenced
this pull request
Aug 29, 2019
* Fix _copy_to * Add comment
pengzhao-intel
pushed a commit
that referenced
this pull request
Aug 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Should fix #15555.
@pengzhao-intel @kostayScr
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments