This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haojin2
requested review from
haojin2 and
reminisce
and removed request for
szha
August 12, 2019 18:36
Some tests are failing, please investigate. |
reminisce
reviewed
Aug 12, 2019
I think you will need to modify the |
ckt624
force-pushed
the
master_det
branch
5 times, most recently
from
August 14, 2019 06:01
e5bee2d
to
46f9d54
Compare
haojin2
reviewed
Aug 14, 2019
haojin2
reviewed
Aug 14, 2019
ckt624
force-pushed
the
master_det
branch
2 times, most recently
from
August 17, 2019 08:59
86e269a
to
0a4c9da
Compare
Add tests. Add slogdet tests. Add docs Change shapes Change tests. Change slogdet tests Change style.
reminisce
force-pushed
the
master_det
branch
from
September 24, 2019 23:16
0a4c9da
to
e61f336
Compare
7 tasks
reminisce
pushed a commit
that referenced
this pull request
Oct 5, 2019
* Add alias. Add tests. Add slogdet tests. Add docs Change shapes Change tests. Change slogdet tests Change style. * Fix * Fix
reminisce
pushed a commit
that referenced
this pull request
Oct 6, 2019
* Add alias. Add tests. Add slogdet tests. Add docs Change shapes Change tests. Change slogdet tests Change style. * Fix * Fix
reminisce
pushed a commit
that referenced
this pull request
Oct 7, 2019
* Add alias. Add tests. Add slogdet tests. Add docs Change shapes Change tests. Change slogdet tests Change style. * Fix * Fix
reminisce
added a commit
to reminisce/mxnet
that referenced
this pull request
Oct 9, 2019
This reverts commit 295fc14.
reminisce
added a commit
that referenced
this pull request
Oct 10, 2019
* Revert "Numpy det and slogdet operators (#15861)" This reverts commit 295fc14. * Delete non-windows test * Revert "Numpy Operators: Inner, Outer, vdot (#15846)" This reverts commit 2df3282. * Revert "Revert "Numpy Operators: Inner, Outer, vdot (#15846)"" This reverts commit 79ceaa7. * Revert "Delete non-windows test" This reverts commit c915877.
aaronmarkham
pushed a commit
to aaronmarkham/incubator-mxnet
that referenced
this pull request
Oct 16, 2019
* Revert "Numpy det and slogdet operators (apache#15861)" This reverts commit 295fc14. * Delete non-windows test * Revert "Numpy Operators: Inner, Outer, vdot (apache#15846)" This reverts commit 2df3282. * Revert "Revert "Numpy Operators: Inner, Outer, vdot (apache#15846)"" This reverts commit 79ceaa7. * Revert "Delete non-windows test" This reverts commit c915877.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements numpy.linalg.det and slogdet. See
https://docs.scipy.org/doc/numpy/reference/generated/numpy.linalg.det.html
https://docs.scipy.org/doc/numpy/reference/generated/numpy.linalg.slogdet.html
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments
@haojin2 @reminisce