This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[Numpy] Basic indexing in symbolic interface #15905
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
haojin2
reviewed
Aug 16, 2019
haojin2
reviewed
Aug 16, 2019
haojin2
reviewed
Aug 16, 2019
haojin2
reviewed
Aug 16, 2019
haojin2
reviewed
Aug 16, 2019
haojin2
reviewed
Aug 16, 2019
sxjscience
reviewed
Oct 25, 2019
" -5 use the product of two consecutive dimensions of the input" | ||
" shape as the output" | ||
" -6 split one dimension of the input into two dimensions passed" | ||
" subsequent to -6 in the new shape"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find that the reverse flag in the original nd.reshape
will also be useful.
Sometimes, I'd like to reshape (..., N * C) --> (..., N, C), and could not do so without the reverse option.
9 tasks
closing as inactive duplicate of #16621 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement basic slicing in symbolic interface
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Add npx_reshape to support reshape with special flags
Implement basic slicing in _symbol.py : __getitem__, basic slicing means slicing with
A flag
_output_is_list
is added to symbol class in the frontend to differentiate the cases in which a symbol with only one output Node is conceptually a list, eg:split(x, 1)
Group
function in Symbolsave
,save_json_string
,load
,load_json_string
to specially take care of the newly added flagComments
Based on the current implementation, any operator that generates a list-like output should register their name in the list
python/mxnet/base.py:_NP_OUTPUT_IS_LIST_OPERATORS
Thank @reminisce and @haojin2 for reviewing