This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
added check for empty params file and unknown param (not arg/aux) #15917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anirudh2290
approved these changes
Aug 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the additional warning if save_dict is not dict as discussed offline
Thanks @anirudh2290! Added the additional warning message. @zachgk for review/merge? |
zachgk
approved these changes
Aug 15, 2019
anirudhacharya
pushed a commit
to anirudhacharya/mxnet
that referenced
this pull request
Aug 20, 2019
…ache#15917) * added check for empty params file and unknown param (not arg/aux) * changed exception to warning for unknown params * removed unnecessary MXNetError import * added warning message is params is empty * fixed print * fixed formatting * missing paren
samskalicky
pushed a commit
to samskalicky/incubator-mxnet
that referenced
this pull request
Aug 28, 2019
…ache#15917) * added check for empty params file and unknown param (not arg/aux) * changed exception to warning for unknown params * removed unnecessary MXNetError import * added warning message is params is empty * fixed print * fixed formatting * missing paren
anirudh2290
pushed a commit
that referenced
this pull request
Aug 28, 2019
…5917) * added check for empty params file and unknown param (not arg/aux) * changed exception to warning for unknown params * removed unnecessary MXNetError import * added warning message is params is empty * fixed print * fixed formatting * missing paren
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes error when loading empty params file (fixes #15916)
Added check for unknown params in params file, was silently ignoring before
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.