This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Add Large tensor vector test cases #15941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o test_large_vector
|
@ChaiBapchya only test cases to verify Large Vector are being added. Update the description and title accordingly |
ChaiBapchya
changed the title
|
Updated. @access2rohit |
apeforest
reviewed
Aug 21, 2019
apeforest
reviewed
Aug 21, 2019
| @@ -742,7 +761,7 @@ def test_activation(): | |||
| # Hyperbolic tangent (tanh) | |||
| # y = (exp(x)-exp(-x))/(exp(x)+exp(-x)) | |||
| a = mx.nd.Activation(a, act_type="tanh") | |||
| tanh_x = (np.exp(-2)-np.exp(2))/(np.exp(-2)+np.exp(2)) | |||
| tanh_x = (np.exp(test_x)-np.exp(-test_x))/(np.exp(test_x)+np.exp(-test_x)) | |||
There was a problem hiding this comment.
nit: add space around operators. Do this across the entire file.
There was a problem hiding this comment.
PEP8 / pylint both didn't give error for this. I'll do it but is there some other linting tool apart from PEP8 and pylint?
If it's google style guide tool?
Is this the way to go?
https://stackoverflow.com/questions/29597618/is-there-a-tool-to-lint-python-based-on-the-google-style-guide
apeforest
reviewed
Aug 21, 2019
apeforest
reviewed
Aug 21, 2019
apeforest
reviewed
Aug 21, 2019
apeforest
reviewed
Aug 21, 2019
apeforest
reviewed
Aug 21, 2019
4 tasks
ChaiBapchya
force-pushed
the
lts_vector
branch
from
fa2de93 to
1e9349a
Compare
anirudh2290
reviewed
Aug 27, 2019
5 tasks
access2rohit
approved these changes
Sep 2, 2019
apeforest
reviewed
Sep 3, 2019
|
gyshi
pushed a commit
to gyshi/incubator-mxnet
that referenced
this pull request
Sep 7, 2019
* add random ops * add shuffle to test large array * shape evaluation after value check * add log, exponent, power ops * fix sequence reverse issue in test_large_array and add sequence ops to test_large_vector * add binary arithmetic * fix lint, minor mistakes in large_array; add nn op to tensor * Trigger notification coz of test_operator.test_laop_6 error * Trigger notification coz of test_operator.test_laop_6 error * Trigger notification bcoz R failures * address comments * normal distribution assert statement fix; randint dtype check * correct layernorm and shuffle * layer norm numpy flaky hence removed, dropout shape fix * comment not working ops * fix multi * Trigger notification * fix seq reverse, uncomment seq mask as it works * index fix and uncomment test * index fix * seq_reverse index fix * uncomment seq reverse test and handle static typecasts * removing commented ops * resolve merge conflict * teardown, lint, remove redundant functions * fix shape assertions and randint low,high * remove waits, add teardown to large_array, change randint assert in large array
gyshi
pushed a commit
to gyshi/incubator-mxnet
that referenced
this pull request
Sep 7, 2019
* add random ops * add shuffle to test large array * shape evaluation after value check * add log, exponent, power ops * fix sequence reverse issue in test_large_array and add sequence ops to test_large_vector * add binary arithmetic * fix lint, minor mistakes in large_array; add nn op to tensor * Trigger notification coz of test_operator.test_laop_6 error * Trigger notification coz of test_operator.test_laop_6 error * Trigger notification bcoz R failures * address comments * normal distribution assert statement fix; randint dtype check * correct layernorm and shuffle * layer norm numpy flaky hence removed, dropout shape fix * comment not working ops * fix multi * Trigger notification * fix seq reverse, uncomment seq mask as it works * index fix and uncomment test * index fix * seq_reverse index fix * uncomment seq reverse test and handle static typecasts * removing commented ops * resolve merge conflict * teardown, lint, remove redundant functions * fix shape assertions and randint low,high * remove waits, add teardown to large_array, change randint assert in large array
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Sep 25, 2019
* add random ops * add shuffle to test large array * shape evaluation after value check * add log, exponent, power ops * fix sequence reverse issue in test_large_array and add sequence ops to test_large_vector * add binary arithmetic * fix lint, minor mistakes in large_array; add nn op to tensor * Trigger notification coz of test_operator.test_laop_6 error * Trigger notification coz of test_operator.test_laop_6 error * Trigger notification bcoz R failures * address comments * normal distribution assert statement fix; randint dtype check * correct layernorm and shuffle * layer norm numpy flaky hence removed, dropout shape fix * comment not working ops * fix multi * Trigger notification * fix seq reverse, uncomment seq mask as it works * index fix and uncomment test * index fix * seq_reverse index fix * uncomment seq reverse test and handle static typecasts * removing commented ops * resolve merge conflict * teardown, lint, remove redundant functions * fix shape assertions and randint low,high * remove waits, add teardown to large_array, change randint assert in large array
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Sep 25, 2019
* add random ops * add shuffle to test large array * shape evaluation after value check * add log, exponent, power ops * fix sequence reverse issue in test_large_array and add sequence ops to test_large_vector * add binary arithmetic * fix lint, minor mistakes in large_array; add nn op to tensor * Trigger notification coz of test_operator.test_laop_6 error * Trigger notification coz of test_operator.test_laop_6 error * Trigger notification bcoz R failures * address comments * normal distribution assert statement fix; randint dtype check * correct layernorm and shuffle * layer norm numpy flaky hence removed, dropout shape fix * comment not working ops * fix multi * Trigger notification * fix seq reverse, uncomment seq mask as it works * index fix and uncomment test * index fix * seq_reverse index fix * uncomment seq reverse test and handle static typecasts * removing commented ops * resolve merge conflict * teardown, lint, remove redundant functions * fix shape assertions and randint low,high * remove waits, add teardown to large_array, change randint assert in large array
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Sep 25, 2019
* add random ops * add shuffle to test large array * shape evaluation after value check * add log, exponent, power ops * fix sequence reverse issue in test_large_array and add sequence ops to test_large_vector * add binary arithmetic * fix lint, minor mistakes in large_array; add nn op to tensor * Trigger notification coz of test_operator.test_laop_6 error * Trigger notification coz of test_operator.test_laop_6 error * Trigger notification bcoz R failures * address comments * normal distribution assert statement fix; randint dtype check * correct layernorm and shuffle * layer norm numpy flaky hence removed, dropout shape fix * comment not working ops * fix multi * Trigger notification * fix seq reverse, uncomment seq mask as it works * index fix and uncomment test * index fix * seq_reverse index fix * uncomment seq reverse test and handle static typecasts * removing commented ops * resolve merge conflict * teardown, lint, remove redundant functions * fix shape assertions and randint low,high * remove waits, add teardown to large_array, change randint assert in large array
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added test for large vector for following ops
add,sub,rsub,neg,mul,div,rdiv,mod,rmod,imod,powLayerNormandBatchNormsequence_last,sequence_reverse, `sequence_mask``exp,expm1,log,log2,log10,log1psqrt,rsqrt,cbrt,rcbrt,square,reciprocalrandom.exponential,random.gamma,random.generalized_negative_binomial,random.multinomial,random.negative_binomial,random.normal,random.poisson,random.randnMinor changes to large tensor array op
Fix indexing issue for
sequence_last,sequence_reverseChecklist
Essentials
Please feel free to remove inapplicable items for your PR.