-
Notifications
You must be signed in to change notification settings - Fork 6.8k
detect number of procs during sphinx build #16512
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also if we have troubles with make we can use a python thing to build the sphinx docs, there are python alternatives. Make is just a dumb depgraph.
This file is what's included in Sphinx so people expect it. But sure, we could use something different to invoke sphinx. |
Kind of ridiculous how many times I've had to restart the tests on this PR. Restarting centos-gpu now due to failing here: http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Fcentos-gpu/detail/PR-16512/4/pipeline |
Can we collect the failures to understand what were the root causes? |
In the one you linked S3 failed, so we could add a retry. |
Description
I ran into a build issue when making the python docs on an instance with 16 processors. The makefile for sphinx was hardcoded to 32 which I guess was fine for CI.
The error was like this:
I turned off parallel builds with Sphinx and it worked, then switched to this new code that detects the number of processors in the Makefile and that worked.
Testing