Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

true_divide and broadcast_mul with mixed precisions #16631

Closed
wants to merge 4 commits into from

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Oct 25, 2019

Description

Coverage for true_divide between floating types and integer types (including boolean).
Coverage for multiply between floating types and boolean type. (mainly for )
Also a side fix for cumsum with boolean inputs.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • true_divide mixed-precision support
  • multiply mixed-precision support
  • cumsum boolean input support
  • unit tests for all of above

Comments

@reminisce

@haojin2 haojin2 requested a review from reminisce October 25, 2019 20:52
@haojin2 haojin2 self-assigned this Oct 25, 2019
@haojin2 haojin2 added the Numpy label Oct 25, 2019
@haojin2 haojin2 force-pushed the mixed_binary_ops branch 2 times, most recently from a85214c to a040bc6 Compare October 28, 2019 10:36
@haojin2
Copy link
Contributor Author

haojin2 commented Oct 31, 2019

Closing temporarily to stop CI runs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant